Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): use null for null body responses #495

Merged
merged 3 commits into from
Aug 7, 2023
Merged

fix(web): use null for null body responses #495

merged 3 commits into from
Aug 7, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Aug 7, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Reported by @atinux > @danielroe

This fixes the issue with null body responses in h3. Once nitro migrates to the web handler, it should fix all possible targets.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 requested a review from danielroe August 7, 2023 11:40
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #495 (b7b15f7) into main (f3394ee) will increase coverage by 0.01%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##             main     #495      +/-   ##
==========================================
+ Coverage   82.37%   82.38%   +0.01%     
==========================================
  Files          31       31              
  Lines        3500     3508       +8     
  Branches      522      523       +1     
==========================================
+ Hits         2883     2890       +7     
- Misses        617      618       +1     
Files Changed Coverage Ξ”
src/adapters/web.ts 98.03% <88.88%> (-1.97%) ⬇️

@pi0 pi0 merged commit b96aa69 into main Aug 7, 2023
@pi0 pi0 deleted the fix/null-body branch August 7, 2023 11:53
danielroe pushed a commit that referenced this pull request Aug 7, 2023
@pi0 pi0 mentioned this pull request Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants