Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix deleteCookie description #487

Merged
merged 1 commit into from
Aug 7, 2023
Merged

docs: fix deleteCookie description #487

merged 1 commit into from
Aug 7, 2023

Conversation

edimitchel
Copy link
Contributor

πŸ”— Linked issue

No issue related, very small issue I spot by diving in the code.

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

The description was wrong on deleteCookie function

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #487 (5f6efb3) into main (7fc1d8b) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #487   +/-   ##
=======================================
  Coverage   82.79%   82.79%           
=======================================
  Files          31       31           
  Lines        3424     3424           
  Branches      514      514           
=======================================
  Hits         2835     2835           
  Misses        589      589           
Files Changed Coverage Ξ”
src/utils/cookie.ts 93.78% <100.00%> (ΓΈ)

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 changed the title docs: wrong function description on deleteCookie docs: fix deleteCookie description Aug 7, 2023
@pi0 pi0 merged commit b3427f5 into unjs:main Aug 7, 2023
@pi0 pi0 mentioned this pull request Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants