-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: object-syntax event handlers #485
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #485 +/- ##
==========================================
- Coverage 82.79% 82.34% -0.45%
==========================================
Files 31 31
Lines 3424 3473 +49
Branches 514 516 +2
==========================================
+ Hits 2835 2860 +25
- Misses 589 613 +24
|
pi0
reviewed
Aug 4, 2023
13 tasks
pi0
approved these changes
Aug 7, 2023
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
#417
resolves #424
β Type of change
π Description
This supports object-syntax event handlers with the following syntax:
Helper validate functions need to be drafted that type-hint
event
and infer a return type. (I would suggest we also suggestvalidate: { body: () => {}, query: () => {} }
which I think will be easier to directly get a type from as user can just return the validated body/query, which we can then flow through into rest of handlers.)π Checklist