Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(defineLazyEventHandler): infer return type #442

Merged
merged 1 commit into from
Jul 17, 2023
Merged

fix(defineLazyEventHandler): infer return type #442

merged 1 commit into from
Jul 17, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Currently we lose all type inference with lazy event handlers. This fixes it by ensuring types flow upward..

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Jul 16, 2023
@danielroe danielroe requested a review from pi0 July 16, 2023 13:15
@danielroe danielroe self-assigned this Jul 16, 2023
@codecov
Copy link

codecov bot commented Jul 16, 2023 •
edited
Loading

Codecov Report

Merging #442 (22e1287) into main (d11f817) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #442   +/-   ##
=======================================
  Coverage   77.74%   77.74%           
=======================================
  Files          26       26           
  Lines        2692     2692           
  Branches      393      397    +4     
=======================================
  Hits         2093     2093           
  Misses        599      599
Impacted Files Coverage Ξ”
src/event/utils.ts 64.19% <100.00%> (ΓΈ)

danielroe added a commit to danielroe/roe.dev that referenced this pull request Jul 16, 2023
@danielroe
fix: infer return types for lazy event handlers
550ade9 
unjs/h3#442
@pi0 pi0 changed the title fix: infer return type of lazy event handlers fix(defineLazyEventHandler): infer return type Jul 17, 2023
pi0
pi0 approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 merged commit a8fecea into main Jul 17, 2023
@pi0 pi0 deleted the fix/lazy-event-handler-types branch July 17, 2023 13:57
@pi0 pi0 mentioned this pull request Aug 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees

@danielroe danielroe

Labels
bug Something isn't working ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielroe @pi0 @Hebilicious