-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add event.method
and event.headers
#429
Conversation
event.method
and event.headers
Codecov Report
@@ Coverage Diff @@
## main #429 +/- ##
==========================================
- Coverage 76.82% 75.16% -1.66%
==========================================
Files 26 26
Lines 2554 2569 +15
Branches 367 369 +2
==========================================
- Hits 1962 1931 -31
- Misses 592 638 +46
|
Thanks for the PR! I've made a couple of updates to use a getter with lazy evaluation and keep the public interface read-only. Similar to Fix tests for Node 16 not having global Headers. In H3 we have a working polyfill but thinking to node depend on for best web compatible behavior. |
π Linked issue
#423, #73
β Type of change
π Description
This PR adds
event.method
andevent.headers
support.π Checklist