-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: parse rawBody buffer when isBuffer #369
Conversation
Flip order of operation. Fixes issue: ``` [request error] [unhandled] [500] The first argument must be of type string or an instance of Buffer, ArrayBuffer, or Array or an Array-like Object. Received an instance of Promise ```
@pi0 Ready for merge |
I just ran into this error message while deploying deploying Nuxt 3 on Firebase and trying to get VueFire auth sessions working. I hope the fix will be merged soon and working 👍. I've tried to get this up and deployed but since it's not released on NPM I have not figured out how to get it onto Firebase to try out. I hope this get's tested / verified / merged sometime soon as it appears to be a serious holdup for our project right now. |
Link issue #371 |
Any progress? |
@sawa-ko You can use the workaround I mentioned in the issue #371 (comment) Basically downgrading to version |
Hi and sorry for the late review. I think the logic is correct. rawBody util is supposed to return a buffer or convert it to buffer. Is this issue only reproducable with nitro and firebase preset? |
This problem also happens on nuxt3 nodejs preset, |
Sorry again for delay on this issue. I could just locally reproduce it. The problem was type checking on unresolved promises fixed by 2e472e8 Please remove any Side note: Please consider opening an issue with reproduction in such cases. It could help to resolve much earlier 🙏🏼 |
Flip order of operation.
Fixes issue: