-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(readBody): validate requests with application/json
content type
#207
Conversation
@pi0 this is now ready for review |
Codecov Report
@@ Coverage Diff @@
## main #207 +/- ##
==========================================
+ Coverage 77.36% 77.74% +0.38%
==========================================
Files 26 26
Lines 2655 2692 +37
Branches 383 393 +10
==========================================
+ Hits 2054 2093 +39
+ Misses 601 599 -2
|
@tobiasdiez Nice pr; I ended up fixing the encoding signature too just to realize that you had a fix haha |
@pi0 merged in the latest version from main, so this PR is ready for review again |
@pi0 would appreciate if you could have a look at this PR. Thanks! |
@tobiasdiez good PR 👍 |
@pi0 I think this is overall a good change, would like to know what you think before approving. We would need to keep the tests and refactor the logic, as there's a lot of conflicts now. |
Hi, dear @tobiasdiez, and sorry for checking this late. Before merging, I made a few changes to fix the behavior matching PR description (we strictly validate json body only when n the future please consider splitting fixes to allow iterating faster and having a clear changelog 🙏🏼 Cheers! |
application/json
content type
application/json
content typeapplication/json
content type
Follow-up from #201. Changes are:
strict
that throws an error if the input is not valid JSON destr#11.readBodyRaw