Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): display the current directory when cloning into current dir #132

Merged
merged 3 commits into from
Dec 23, 2023
Merged

fix(cli): display the current directory when cloning into current dir #132

merged 3 commits into from
Dec 23, 2023

Conversation

uncenter
Copy link
Contributor

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

The success message after cloning a template into the current directory is a little confusing:

Screenshot 2023-12-23 at 15 49 58 (kitty)

Where was it cloned? Did it work?

Not sure if this is the ideal solution for y'all but with this PR it looks like this instead:

Screenshot 2023-12-23 at 15 52 52 (kitty)

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

src/cli.ts Outdated Show resolved Hide resolved
@pi0 pi0 changed the title fix: display "the current directory" when cloning into the cwd instead of nothing fix(cli): display the current directory when cloning into current dir Dec 23, 2023
@uncenter
Copy link
Contributor Author

As you suggested, looks like this now:

Screenshot 2023-12-23 at 16 14 56 (kitty)

src/cli.ts Outdated Show resolved Hide resolved
@uncenter
Copy link
Contributor Author

Yep, that works. One less process.cwd() call!

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link

codecov bot commented Dec 23, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (cb82386) 54.80% compared to head (a95f9d8) 54.93%.
Report is 2 commits behind head on main.

Files Patch % Lines
src/cli.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #132      +/-   ##
==========================================
+ Coverage   54.80%   54.93%   +0.13%     
==========================================
  Files           7        7              
  Lines         604      608       +4     
  Branches       46       47       +1     
==========================================
+ Hits          331      334       +3     
- Misses        272      273       +1     
  Partials        1        1              

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@pi0 pi0 merged commit dc41245 into unjs:main Dec 23, 2023
3 of 4 checks passed
@uncenter uncenter deleted the fix/clone-to-current-dir branch December 23, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants