-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for macOS Catalina #33
base: master
Are you sure you want to change the base?
Conversation
Fixes #30 #32 #25 |
@ShikaSD Back then, few days after I commented I even found a better solution. The patch of not giving you the mac-addr of the found devices was implemented pretty badly, they just changed few lines in the CoreWLAN framework. It can simply be bypassed if you call the functions from the underlying Apple80211 framework yourself (exactly what CoreWLAN does). This way you can have locationservices disabled. I even created my own repo and hosted it, but I made it private after a while. |
@anonymouz4 That's great! Can you share the repo or make a pull request? Thanks! |
@ShikaSD I downloaded your repo and built it in xcode. It did prompt me for location services and I clicked OK but it still crashed the computer. I'm running Mojave still so maybe that's it? Is there anything else you need to do to enable location services? |
@wootwoot1234 Tbh, I don't have Mojave around to test it, but "crashed the computer" sounds rather weird :) |
I know it's weird but I'm not the only person experiencing it. Many people list that as an issue, for example, #24. The rebooting is even referenced in the issues you listed as fixed. I'll update my OS and tray again. Thanks! |
@ShikaSD is there a way to manually check if the location services are actually enabled? |
@wootwoot1234 I could send you a test version if you'd like |
Yes, that would be great!
…On Mon, Dec 16, 2019 at 12:59 PM anonymouz4 ***@***.***> wrote:
@wootwoot1234 <https://github.com/wootwoot1234> I could send you a test
version if you'd like
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#33?email_source=notifications&email_token=AADGOGMQOBNIELT27EDIWLLQY7FYTA5CNFSM4JY74HBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEG7XIQY#issuecomment-566195267>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADGOGIT2GFXLX5LV46DJH3QY7FYTANCNFSM4JY74HBA>
.
|
@ShikaSD its still crashing on Catalina. I’m running it on a late 2018 MacBook Pro. |
@wootwoot1234 you got an email? |
@anonymouz4 thanks for the file but it still is crashing my computer. I'm not sure what settings are different on my computer that is causing this issue. |
It is also crashing my MacBook Pro running Catalina 10.15.2 |
Not crashing on 10.15.2 (2019 MacBook Pro). Thanks for your work, @ShikaSD. |
@wootwoot1234 nothing that I can think of. This laptop is about 2 weeks old and I haven't done too much mucking about. I built the project with the latest Xcode and commandline tools installed. |
It is crashing on my MacBook Air (Retina, 13-inch, 2018) 10.15.2 (19C57) xcode-select version 2373 |
Can anyone teach me how to apply this code in layman terms? I am new to this and I really need this program |
@@ -134,6 +134,7 @@ - (void)scanInBackground { | |||
self->interfaceName = interface.interfaceName; | |||
NSError * error = nil; | |||
NSArray * nets = [[interface scanForNetworksWithSSID:nil error:&error] allObjects]; | |||
NSLog(@"Nets%@", nets.firstObject); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove these logs or format them nicer if you believe they should be kept in master (edit: this applies to this log and the log below)
Doesn't fix crashing but everything else 0x0XDev/JamWiFi |
You could've cloned the repo and worked off of it instead instead of wiping the git history clean. It is also worth noting that this original codebase is not licensed under any open-source license. |
@RSully I actually created it for myself and had no intention of making it public, thats why I wanted to start fresh, not cloning. As you can see, I kept it private for 6 month now, but since people asked if I would share bc their version didn't work, I just tried to help. If it bother you that much, I could very well make it private again |
i get '' Application cannot be opened'' when ever I open the app, any idea? |
@drakenass maybe download master and build it yourself. But for issues, open one on that repo, not here |
@anonymouz4 |
@ShikaSD macOS Catalina 10.15.2, bssid is displayed, on second page connected devices ssids are displayed, but when I try to go to third step with all connected devices selected, my mac crashes in few seconds. |
Dear all (ShikaSD, wootwoot1234, anonymouz4), |
I think this needs to be tested on newer Macs, ie: 2019 models. |
Is it necessary to build it from Xcode? I am really not sure how to run it. If anyone can share briefly how this is run, I would appreciate it a lot |
Asked for location permission on app start.