Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for macOS Catalina #33

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix for macOS Catalina #33

wants to merge 4 commits into from

Conversation

ShikaSD
Copy link

@ShikaSD ShikaSD commented Dec 10, 2019

Asked for location permission on app start.

@ShikaSD
Copy link
Author

ShikaSD commented Dec 10, 2019

Fixes #30 #32 #25
Thanks to @anonymouz4 for explanation

@anonymouz4
Copy link

@ShikaSD Back then, few days after I commented I even found a better solution. The patch of not giving you the mac-addr of the found devices was implemented pretty badly, they just changed few lines in the CoreWLAN framework. It can simply be bypassed if you call the functions from the underlying Apple80211 framework yourself (exactly what CoreWLAN does). This way you can have locationservices disabled. I even created my own repo and hosted it, but I made it private after a while.

@wootwoot1234
Copy link

@anonymouz4 That's great! Can you share the repo or make a pull request? Thanks!

@wootwoot1234
Copy link

@ShikaSD I downloaded your repo and built it in xcode. It did prompt me for location services and I clicked OK but it still crashed the computer. I'm running Mojave still so maybe that's it? Is there anything else you need to do to enable location services?

@ShikaSD
Copy link
Author

ShikaSD commented Dec 16, 2019

@wootwoot1234 Tbh, I don't have Mojave around to test it, but "crashed the computer" sounds rather weird :)
I just went through the path of least resistance (requesting location), which helped me to make this tool work. Could it be some bug in macOS kernel, which crashes the system or smth?

@wootwoot1234
Copy link

I know it's weird but I'm not the only person experiencing it. Many people list that as an issue, for example, #24. The rebooting is even referenced in the issues you listed as fixed.

I'll update my OS and tray again. Thanks!

@wootwoot1234
Copy link

@ShikaSD is there a way to manually check if the location services are actually enabled?

@anonymouz4
Copy link

@wootwoot1234 I could send you a test version if you'd like

@wootwoot1234
Copy link

wootwoot1234 commented Dec 16, 2019 via email

@wootwoot1234
Copy link

@ShikaSD its still crashing on Catalina. I’m running it on a late 2018 MacBook Pro.

@anonymouz4
Copy link

@wootwoot1234 you got an email?

@wootwoot1234
Copy link

@anonymouz4 thanks for the file but it still is crashing my computer. I'm not sure what settings are different on my computer that is causing this issue.

@ajkblue
Copy link

ajkblue commented Dec 16, 2019

It is also crashing my MacBook Pro running Catalina 10.15.2

@jesse-c
Copy link

jesse-c commented Dec 27, 2019

Not crashing on 10.15.2 (2019 MacBook Pro).

Thanks for your work, @ShikaSD.

@wootwoot1234
Copy link

Not crashing on 10.15.2 (2019 MacBook Pro).

Thanks for your work, @ShikaSD.

@jesse-c Did you install any drivers or change any settings that you can think of?

@jesse-c
Copy link

jesse-c commented Dec 27, 2019

@wootwoot1234 nothing that I can think of. This laptop is about 2 weeks old and I haven't done too much mucking about.

I built the project with the latest Xcode and commandline tools installed.

@ctopherwilliams
Copy link

It is crashing on my MacBook Air (Retina, 13-inch, 2018) 10.15.2 (19C57)

xcode-select version 2373

@mekel1991
Copy link

Can anyone teach me how to apply this code in layman terms? I am new to this and I really need this program

@@ -134,6 +134,7 @@ - (void)scanInBackground {
self->interfaceName = interface.interfaceName;
NSError * error = nil;
NSArray * nets = [[interface scanForNetworksWithSSID:nil error:&error] allObjects];
NSLog(@"Nets%@", nets.firstObject);
Copy link

@RSully RSully Dec 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove these logs or format them nicer if you believe they should be kept in master (edit: this applies to this log and the log below)

@anonymouz4
Copy link

Doesn't fix crashing but everything else 0x0XDev/JamWiFi

@RSully
Copy link

RSully commented Dec 31, 2019

@anonymouz4

You could've cloned the repo and worked off of it instead instead of wiping the git history clean.

It is also worth noting that this original codebase is not licensed under any open-source license.

@anonymouz4
Copy link

anonymouz4 commented Jan 1, 2020

@RSully I actually created it for myself and had no intention of making it public, thats why I wanted to start fresh, not cloning. As you can see, I kept it private for 6 month now, but since people asked if I would share bc their version didn't work, I just tried to help. If it bother you that much, I could very well make it private again

@drakenass
Copy link

Doesn't fix crashing but everything else 0x0XDev/JamWiFi

i get '' Application cannot be opened'' when ever I open the app, any idea?

@anonymouz4
Copy link

@drakenass maybe download master and build it yourself. But for issues, open one on that repo, not here

@drakenass
Copy link

@anonymouz4
It was fixed. A quick general question though concerning the app it self, why can’t I use the network after jamming it on the Mac?

@kushney
Copy link

kushney commented Jan 15, 2020

@ShikaSD macOS Catalina 10.15.2, bssid is displayed, on second page connected devices ssids are displayed, but when I try to go to third step with all connected devices selected, my mac crashes in few seconds.

@ward44120
Copy link

Dear all (ShikaSD, wootwoot1234, anonymouz4),
I am really sorry, I am a total beginner on GitHub. Does anyone could tell me the procedure to apply those recommended fix to my application JamWiFi ? Thanks all for your help, Olivier

@syddo
Copy link

syddo commented Mar 28, 2020

I think this needs to be tested on newer Macs, ie: 2019 models.
It doesn't sound like a fix if the machine "crash" during the use this app.

@Ne7WoRK
Copy link

Ne7WoRK commented Apr 10, 2020

Is it necessary to build it from Xcode? I am really not sure how to run it. If anyone can share briefly how this is run, I would appreciate it a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.