Fix flaky ZNE factory + observable test #2602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2602 +/- ##
=======================================
Coverage 98.73% 98.73%
=======================================
Files 92 92
Lines 4176 4176
=======================================
Hits 4123 4123
Misses 53 53 ☔ View full report in Codecov by Sentry. |
cosenal
requested changes
Dec 13, 2024
| @@ -94,21 +94,23 @@ def executor(circuit) -> float: | |||
| def test_with_observable_batched_factory(executor): | |||
There was a problem hiding this comment.
you are not using the executor argument anywhere in the test, which means you are not using all the parameter values 🤔
There was a problem hiding this comment.
Good catch! That was left over from testing and never got changed back. Fixed in 52765b7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces a test that would fail occasionally with a deterministic assertion based on mocking the
BatchedFactoryobject. I did keep one assertion regarding the actual value, but I'm pretty sure it's also deterministic.fixes #1896
cc @Shivansh20128 since you ran into this recently.