Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log param to calibration guide #2568

Merged
merged 8 commits into from
Nov 22, 2024

Conversation

bdg221
Copy link
Collaborator

@bdg221 bdg221 commented Nov 13, 2024

Description

Fixes #2516
Fixes #2575

This PR adds information about the run() method's log param and also the log_results_flat() and log_results_cartesian() methods to the Calibration Guide.

Also, the run() method's docstring was update with information about the log parameter.

License

  • I license this contribution under the terms of the GNU GPL, version 3 and grant Unitary Fund the right to provide additional permissions as described in section 7 of the GNU GPL, version 3.

Before opening the PR, please ensure you have completed the following where appropriate.

@bdg221 bdg221 requested a review from natestemen November 13, 2024 00:16
@bdg221 bdg221 self-assigned this Nov 13, 2024
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.72%. Comparing base (a629c05) to head (12f5ae6).
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2568   +/-   ##
=======================================
  Coverage   98.72%   98.72%           
=======================================
  Files          92       92           
  Lines        4161     4168    +7     
=======================================
+ Hits         4108     4115    +7     
  Misses         53       53           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@bdg221 bdg221 force-pushed the callibration_docs_log_param branch from 515a95d to 8edbbb9 Compare November 13, 2024 16:36
Copy link
Member

@natestemen natestemen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! Very handy to have documented.

Can you also add a more thorough docstring for the Calibrator.run method as part of this?

docs/source/guide/calibrators.md Outdated Show resolved Hide resolved
Copy link
Member

@natestemen natestemen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Brian! Just a few nits, but good to go once those are addressed.

docs/source/guide/calibrators.md Outdated Show resolved Hide resolved
docs/source/guide/calibrators.md Outdated Show resolved Hide resolved
mitiq/calibration/calibrator.py Show resolved Hide resolved
@bdg221 bdg221 requested review from natestemen and cosenal November 19, 2024 03:31
@natestemen natestemen merged commit edeede6 into unitaryfund:main Nov 22, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Calibration run docstring for API-doc
2 participants