-
-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add log param to calibration guide #2568
Add log param to calibration guide #2568
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2568 +/- ##
=======================================
Coverage 98.72% 98.72%
=======================================
Files 92 92
Lines 4161 4168 +7
=======================================
+ Hits 4108 4115 +7
Misses 53 53 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
515a95d
to
8edbbb9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this! Very handy to have documented.
Can you also add a more thorough docstring for the Calibrator.run
method as part of this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Brian! Just a few nits, but good to go once those are addressed.
Description
Fixes #2516
Fixes #2575
This PR adds information about the
run()
method'slog
param and also thelog_results_flat()
andlog_results_cartesian()
methods to the Calibration Guide.Also, the
run()
method's docstring was update with information about thelog
parameter.License
Before opening the PR, please ensure you have completed the following where appropriate.