-
-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flaky test on Windows for REM #2437
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2437 +/- ##
=======================================
Coverage 98.70% 98.70%
=======================================
Files 88 88
Lines 4083 4083
=======================================
Hits 4030 4030
Misses 53 53 ☔ View full report in Codecov by Sentry. |
I think increasing the sample size should fix the failures i.e this PR is technically ready. Will try to rerun the workflow a couple of times to make sure of this. I can't test it locally because I don't have access to a windows device. |
windows-python3.10 is failing due to installation issues. |
running the tests 4 times did not lead to any failures in the linked issue. Noticed a |
as discussed during the community call today, we want to wait for #2441 to be merged before rebasing this PR. @jordandsullivan and @cosenal raised a point that we should look into what's causing this failure instead of simply raising the sample size to ensure the test passes. |
The function in the failing unit test relies on
I still cannot understand why the test would fail/pass at random on |
closing due to #2431 (comment) |
Description
Fixes #2431 by increasing the sample size. Increasing the sample size does not increase the run time by a lot.
This PR also splits up the docs build portion of the github workflows from everything else. This lets us rerun the pytest workflows without requiring us to rerun the docs job.License
Before opening the PR, please ensure you have completed the following where appropriate.