make upload versions unique for TestPyPI #2436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natestemen
added
the
infrastructure
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2436 +/- ##
=======================================
Coverage 98.34% 98.34%
=======================================
Files 89 89
Lines 4105 4105
=======================================
Hits 4037 4037
Misses 68 68 ☔ View full report in Codecov by Sentry. |
|
@natestemen I noticed you reran the failing windows workflow. Do you remember if it was the same as #2431 ? |
|
Action logs are stored for 30 days. You can find logs from the first run here. Indeed it is the same failure. Thanks for opening the issue, and bringing it to my attention here! |
I missed checking this. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TestPyPI uploads are failing (again) because once a version is uploaded with a specific version specifier (say 0.38.0dev), another with the same version cannot be uploaded. To work around this, we added a date the end of the
VERSION.txtfile so each upload is unique. We also removed theverify-versionportion of the action since as long as the upload passes, this gives us enough confidence that our workflow is effective.