Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README with Github discussion link #2419

Merged

Conversation

bdg221
Copy link
Collaborator

@bdg221 bdg221 commented Jun 21, 2024

Description

fixes #2418

This adds the Github discussion link to the main README page.

License

  • I license this contribution under the terms of the GNU GPL, version 3 and grant Unitary Fund the right to provide additional permissions as described in section 7 of the GNU GPL, version 3.

@bdg221 bdg221 requested a review from jordandsullivan June 21, 2024 16:47
@jordandsullivan
Copy link
Contributor

Thanks! Should we maybe add a bit more specificity, e.g. "for code or repo specific questions, submit a Discussion or for time sensitive questions, chat with us on Discord"

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.32%. Comparing base (2f9c00a) to head (aa411cb).
Report is 42 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2419   +/-   ##
=======================================
  Coverage   98.32%   98.32%           
=======================================
  Files          87       87           
  Lines        4048     4048           
=======================================
  Hits         3980     3980           
  Misses         68       68           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdg221
Copy link
Collaborator Author

bdg221 commented Jun 21, 2024

Thanks for the suggestion. I wanted to also point out that if a question is more complex and requires back and forth that the Discussions is preferred.

README.md Outdated
@@ -19,7 +19,7 @@ Error mitigation seeks to reduce these effects at the software level by
compiling quantum programs in clever ways.

Want to know more? Check out our
[documentation](https://mitiq.readthedocs.io/en/stable/guide/guide.html), chat with us on [Discord](http://discord.unitary.fund), and join our weekly community call ([public agenda](https://docs.google.com/document/d/1lZfct4AOCS7fdyWkudcGyER0n0nsCxSFKSicUEeJgtA/)).
[documentation](https://mitiq.readthedocs.io/en/stable/guide/guide.html). For code, repo, or theory questions, especially those requiring more detailed responses, submit a [Discussion](https://github.com/unitaryfund/mitiq/discussions). For time sensitive questions, chat with us on [Discord](http://discord.unitary.fund). Also, join our weekly community call ([public agenda](https://docs.google.com/document/d/1lZfct4AOCS7fdyWkudcGyER0n0nsCxSFKSicUEeJgtA/)).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding more context. Just to make sure it's readable, could we split into bullet points perhaps?

  • docs
  • discussions
  • time sensitive or casual

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I split it into bullet points and also added on Discord for the weekly community call.

README.md Outdated
[documentation](https://mitiq.readthedocs.io/en/stable/guide/guide.html).
- For code, repo, or theory questions, especially those requiring more detailed responses, submit a [Discussion](https://github.com/unitaryfund/mitiq/discussions).
- For casual or time sensitive questions, chat with us on [Discord](http://discord.unitary.fund).
- Join our weekly community call ([public agenda](https://docs.google.com/document/d/1lZfct4AOCS7fdyWkudcGyER0n0nsCxSFKSicUEeJgtA/)) on [Discord](http://discord.unitary.fund).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic. I would just swap the order of the agenda and link to discord:

community call on Discord (public agenda).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm, you are good to merge!

Copy link
Contributor

@jordandsullivan jordandsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@jordandsullivan jordandsullivan merged commit 20732a0 into unitaryfund:main Jun 24, 2024
16 checks passed
cosenal pushed a commit that referenced this pull request Jun 26, 2024
* Update README with Github discussion link

* Changed the wording to give more context

* Changed formatting to make it more readable

* Finalized wording
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include Discussions on README.md
2 participants