Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tip for generating release notes with GH handles #2398

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Conversation

cosenal
Copy link
Contributor

@cosenal cosenal commented Jun 3, 2024

Documenting a tip for generating release notes that include Github handles out of the box, thus removing a tedious step for the release manager.

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.30%. Comparing base (7004026) to head (c66da7e).
Report is 46 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2398   +/-   ##
=======================================
  Coverage   98.30%   98.30%           
=======================================
  Files          87       87           
  Lines        4003     4003           
=======================================
  Hits         3935     3935           
  Misses         68       68           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jordandsullivan jordandsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks for documenting!

@cosenal cosenal merged commit 368158c into main Jun 3, 2024
18 checks passed
@cosenal cosenal deleted the release-note-tip branch June 3, 2024 16:32
Copy link
Member

@natestemen natestemen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 cool stuff 😎

Alternatively, the list of released changes can be generated via [GitHub CLI](https://cli.github.com/) with the following commands:

LATEST_TAG=$(gh release list --repo unitaryfund/mitiq --limit 1 --json tagName --jq '.[0].tagName')
gh api repos/unitaryfund/mitiq/compare/$LATEST_TAG...main --paginate --jq '.commits | reverse | .[] | (.commit.message | split("\n")[0]) + " [@" + .author.login + "]"'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking my understanding here: --paginate is required to ensure we don't just get the first "page" of commits in the case where there are a large number of commits in the release. Is that right?

Copy link
Contributor Author

@cosenal cosenal Jun 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied that --paginate option from an example in the gh api docs, and my interpretation of it was the same as yours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants