-
-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Layerwise Richardson Extrapolation #2329
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2329 +/- ##
=======================================
Coverage 98.19% 98.19%
=======================================
Files 87 87
Lines 4052 4052
=======================================
Hits 3979 3979
Misses 73 73 ☔ View full report in Codecov by Sentry. |
I'll be late to the Community call today due to another appointment right before. Apologies for the delay in adding this RFC! We can discuss the proposed changes async through the Google doc comments if there's not enough time during the community call. |
The plan is to leave this PR unmerged until the RFC is accepted. Anyone who would like to give comments on the RFC is welcome to during the next two (say?) weeks. cc @unitaryfund/engineering |
Andrea left a comment on the RFC that we should keep the LRE and ZNE inference methods separate. Initially, I thought it would be better to move The refactor to the FWIW I do agree with Andrea that this would be a major breaking change. I thought of proposing this breaking change to make it possible for us to extend multivariate extrapolation beyond Richardson extrapolation (in the near future). I would appreciate comments from others on the two comments in the Edit: Maybe, I am missing something here. I'll try to understand why a |
I agree that it would make sense to move all the inference methods into their own module as you describe @purva-thakre . |
Current version of the RFC (without the linked Jupyter notebook) was accepted during this week's community call. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging this, given that the RFC has been accepted.
Layerwise Richardson Extrapolation RFC
Fixes #2224