-
-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Used trusted publishers for testpypi publishing #2320
Conversation
`make install requirements` actually runs `make install`
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2320 +/- ##
==========================================
+ Coverage 98.29% 98.32% +0.02%
==========================================
Files 90 87 -3
Lines 4274 4048 -226
==========================================
- Hits 4201 3980 -221
+ Misses 73 68 -5 ☔ View full report in Codecov by Sentry. |
Reviewer Note: This change is still somewhat experimental and is hard to test thoroughly. We may want to merge these changes with the exception of 20aeef4 which adds trusted publishing for (main) PyPI. This way we can ensure TestPyPI uploads work correctly before adding it to the main upload process. Also if there are issues, it gives us time to fix things before the 0.38 release goes out this Friday (June 28, 2024). |
How do you plan to exclude that commit? Are you going to create a separate PR? |
Easiest thing to do (IMO) would be to add a new commit that is the anti-diff of 20aeef4 (i.e. revert the commit), so that in a follow on PR the commit can be cherry-picked and applied. |
OK, sounds good to me 👍 |
@natestemen LGTM. Do you want to push the anti-diff commit before I approve? |
This reverts commit 20aeef4.
|
Description
This PR fixes the failing testpypi publishing action which runs nightly to ensure Mitiq can be uploaded to PyPI.
In addition it adds a check to ensure the version uploaded to testpypi is what is then later downloaded.
resolves #2150
testpypi
[docs]create an environment (through GitHub) called(this will be done in a follow on PR when this change takes effect for the main release workflow)pypi