-
-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Jupyter cache in gh workflow docs build #2279
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2279 +/- ##
=======================================
Coverage 98.28% 98.28%
=======================================
Files 90 90
Lines 4263 4263
=======================================
Hits 4190 4190
Misses 73 73 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea. Save engineering/CI time 💪🏻.
Had a few questions, and generally since we can't test it ourselves I figured it would be good to do some searching across GitHub to see what other people are doing.
@natestemen comments addressed, PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try it out! I have had some instances locally where I needed to remove something from the cache in order to get the build to work correctly, but I haven't recreated that situation.
Just left one question, but not blocking. Thanks for answering my other questions :)
@@ -54,6 +54,12 @@ jobs: | |||
docker run --rm -idt -p 5000:5000 rigetti/qvm -S | |||
docker run --rm -idt -p 5555:5555 rigetti/quilc -R | |||
|
|||
- name: Fetch Jupyter cache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just checking my understanding: this is both fetching and setting the cache, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. My understanding is that it simply populates the specified path in the container with the content that's in cache.
Unfortunately, because of that linkcheck issue, the build doesn't succeed and the cache is not populated. I will merge anyway, and hopefully we will have a chance to try it out once the build is green. |
@cosenal We could temporarily remove the mitiq/.github/workflows/build.yml Line 63 in 12c7126
And add it back in when the other issue is resolved. |
@purva-thakre Raise a PR and I will approve it right away :) |
* Use Jupyter cache in gh workflow docs build * bump cache action version
Description
This is an attempt to use Github Actions Cache to restore jupyter_cache from one workflow run to the next one. That cache is created by Sphinx Myst-NB because we are setting this in the configuration.
Test
Unfortunately I can't test this with the awesome
act
tool, because this job starts docker in one of the steps (#dockerinception). So only a merge will tell if it works 😬