Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update qibo requirement from ~=0.2.4 to ~=0.2.5 #2216

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 4, 2024

Updates the requirements on qibo to permit the latest version.

Release notes

Sourced from qibo's releases.

Qibo 0.2.5

What's Changed

... (truncated)

Commits
  • b991160 Merge pull request #1243 from qiboteam/qibotn_interface
  • 77c0475 telling quimb to use same threads as qibojit
  • 6e42375 Merge branch 'master' into qibotn_interface
  • 97e206f retrying with new qibotn main
  • da49e0b removing cuquantum
  • 1ae3aa1 Merge pull request #1227 from qiboteam/composite_noise_model
  • 1c01ffa chore: Poetry lock
  • 14e2fe9 Remove instance creation
  • c86ab4f [pre-commit.ci] auto fixes from pre-commit.com hooks
  • da175b1 Add test for setting qibotn backend
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the infrastructure For issues related to building, packaging, and continuous integration. label Mar 4, 2024
@bdg221
Copy link
Collaborator

bdg221 commented Mar 6, 2024

As pointed out by @francescsabater the test_ZNE_workflow_multi_platform[qibo] from test_calibration.py fails with Qibo 0.2.5. From some initial testing, the issue occurs when the circuit uses two classical registers for measurement, but using the same name (creg m0[1]). An example QASM circuit is:

OPENQASM 2.0;
include "qelib1.inc";
qreg q[2];
creg m0[1];
creg m0[1];
y q[0];
y q[1];
rx(0) q[0];
sxdg q[1];
id q[0];
id q[1];
cx q[0],q[1];
z q[0];
x q[1];
cx q[0],q[1];
id q[0];
z q[1];
rx(0) q[0];
sx q[1];
y q[0];
y q[1];
measure q[0] -> m0[0];
measure q[1] -> m0[0];'

This lines up with the error seen as well:
cirq.contrib.qasm_import.exception.QasmException: m0 is already defined at line 6

@dependabot dependabot bot force-pushed the dependabot/pip/qibo-approx-eq-0.2.5 branch 3 times, most recently from bc764b8 to 79c45ac Compare March 12, 2024 15:16
Updates the requirements on [qibo](https://github.com/qiboteam/qibo) to permit the latest version.
- [Release notes](https://github.com/qiboteam/qibo/releases)
- [Commits](qiboteam/qibo@v0.2.4...v0.2.5)

---
updated-dependencies:
- dependency-name: qibo
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/pip/qibo-approx-eq-0.2.5 branch from 79c45ac to 45321fa Compare March 12, 2024 15:17
@bdg221
Copy link
Collaborator

bdg221 commented Mar 12, 2024

As noted above, this error only happens when two qubits are used due to measurement of both qubits.

It appears that there has been a change in the QASM Parser of Qibo from version 0.2.4 to 0.2.5. After converting from a QASM file to Qibo, in version 0.2.4 there is a single measurement gate, while in version 0.2.5 there are 2 measurement gates.

The following screenshots are of the "converted_circuit" object that is returned from interface/conversions.py convert_from_mitiq. This last step is the result of converting a QASM circuit to a Qibo circuit.

0.2.4 - WORKING
image

0.2.5 - BROKEN
image

@francescsabater are you aware of any changes in Qibo that may have broken this part of the QASMParser?

Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 14, 2024

Superseded by #2230.

@dependabot dependabot bot closed this Mar 14, 2024
@dependabot dependabot bot deleted the dependabot/pip/qibo-approx-eq-0.2.5 branch March 14, 2024 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure For issues related to building, packaging, and continuous integration.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant