Update cirq requirement from <1.3.0,>=1.0.0 to >=1.0.0,<1.4.0 #2107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
the
infrastructure
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2107 +/- ##
==========================================
+ Coverage 98.21% 98.24% +0.02%
==========================================
Files 87 87
Lines 4156 4157 +1
==========================================
+ Hits 4082 4084 +2
+ Misses 74 73 -1 ☔ View full report in Codecov by Sentry. |
Updates the requirements on [cirq](https://github.com/quantumlib/cirq) to permit the latest version. - [Release notes](https://github.com/quantumlib/cirq/releases) - [Changelog](https://github.com/quantumlib/Cirq/blob/main/release.md) - [Commits](quantumlib/Cirq@v1.0.0...v1.3.0) --- updated-dependencies: - dependency-name: cirq dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot/pip/cirq-gte-1.0.0-and-lt-1.4.0
branch
from
1b6805a to
5a199b3
Compare
since the method `_all_qubits` was added to cirq.Circuit objects in the 1.3.0 release, and the circuit objects that are read in from a file are older, they do not have the `_all_qubits` property which cirq code now expects. IMO this is good reason not to use pickling for class specific objects. Cirq docs recommend JSON for serializing circuits.
minor formatting changes + code formatting
andreamari
reviewed
Dec 11, 2023
Comment on lines
-245
to
-247
| <!-- | ||
|  | ||
| --> |
There was a problem hiding this comment.
From the diff it seems that some images have been removed. Is this necessary?
There was a problem hiding this comment.
Ah so this is actually a markdown image that was commented out (surrounding by <!-- and -->). I checked that img/rshadows_compare_channels.png does not exist, and the code above this part (and another) does generate the image. So just removing dead lines.
There was a problem hiding this comment.
Ah, I missed they were just comments. Thanks for removing them.
andreamari
approved these changes
Dec 12, 2023
dependabot
bot
deleted the
dependabot/pip/cirq-gte-1.0.0-and-lt-1.4.0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the requirements on cirq to permit the latest version.
Release notes
Sourced from cirq's releases.
... (truncated)
Commits
7df83d7Removing 1.3.0.dev -> 1.3.09b65f68Remote problematic terminology from test (#6368)dbbca73Change master to main in documentation (#6365)ced1383Restore code coverage (#6364)3ac43f6Switch master to main in CI tools and dev tools (#6363)3c6a305Deprecate Cirq-FT module in favour of Qualtran (#6362)cf973a5Remove leftover dummy terms from the Cirq sources (#6358)9142f6aFix MacOS installation instructions for mactex with brew (#6361)6aa9d0dCleanup classical simulator code and fix a couple of bugs (#6344)a55f962Fix typos in the documentation. (#6359)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)