Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add noise level to the PEC calibration log #2045

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

kozhukalov
Copy link
Contributor

@kozhukalov kozhukalov commented Oct 6, 2023

Description

Now it is clear from the log table why
some PEC strategies are better that others.

Fixes #2013


License

  • I license this contribution under the terms of the GNU GPL, version 3 and grant Unitary Fund the right to provide additional permissions as described in section 7 of the GNU GPL, version 3.

Before opening the PR, please ensure you have completed the following where appropriate.

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (696da9e) 98.30% compared to head (ccbc64d) 98.30%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2045   +/-   ##
=======================================
  Coverage   98.30%   98.30%           
=======================================
  Files          87       87           
  Lines        4125     4125           
=======================================
  Hits         4055     4055           
  Misses         70       70           
Files Coverage Δ
mitiq/calibration/calibrator.py 98.61% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kozhukalov kozhukalov force-pushed the issue_2013 branch 2 times, most recently from 51b1df3 to ed9360d Compare October 7, 2023 01:12
@Misty-W Misty-W self-requested a review October 9, 2023 19:46
@Misty-W
Copy link
Contributor

Misty-W commented Oct 13, 2023

@kozhukalov thanks for the PR! Can you show the output printed from the new logs?

@Misty-W Misty-W requested a review from natestemen October 20, 2023 16:22
Now  it is clear from the log table why
some PEC strategies are better that others.

Fixes unitaryfund#2013
@kozhukalov
Copy link
Contributor Author

After we merged this #2038 and with this change the output looks like

PEC results:
┌───────────────┬────────────────┬──────────┬───────────────┬──────────────┬──────────────────────────┬───────────────┬───────────────────┐
│ performance   │ circuit type   │ method   │   noise level │   noise bias │ noise representation     │   noisy error │   mitigated error │
├───────────────┼────────────────┼──────────┼───────────────┼──────────────┼──────────────────────────┼───────────────┼───────────────────┤
│ ✔             │ rb             │ PEC      │         0.001 │            0 │ local_depolarizing_noise │        0.0834 │        0.0300098  │
├───────────────┼────────────────┼──────────┼───────────────┼──────────────┼──────────────────────────┼───────────────┼───────────────────┤
│ ✔             │ ghz            │ PEC      │         0.01  │            0 │ local_depolarizing_noise │        0.0155 │        0.00178515 │
├───────────────┼────────────────┼──────────┼───────────────┼──────────────┼──────────────────────────┼───────────────┼───────────────────┤
│ ✔             │ ghz            │ PEC      │         0.001 │            0 │ local_depolarizing_noise │        0.0155 │        0.0114373  │
├───────────────┼────────────────┼──────────┼───────────────┼──────────────┼──────────────────────────┼───────────────┼───────────────────┤
│ ✘             │ rb             │ PEC      │         0.01  │            0 │ local_depolarizing_noise │        0.0834 │        2.79663    │
└───────────────┴────────────────┴──────────┴───────────────┴──────────────┴──────────────────────────┴───────────────┴───────────────────┘

Copy link
Member

@natestemen natestemen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the slow review. This is great to have.

@natestemen natestemen merged commit 1a955ad into unitaryfund:master Oct 26, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

noise_level missing from calibrator logs
3 participants