-
-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add noise level to the PEC calibration log #2045
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2045 +/- ##
=======================================
Coverage 98.30% 98.30%
=======================================
Files 87 87
Lines 4125 4125
=======================================
Hits 4055 4055
Misses 70 70
☔ View full report in Codecov by Sentry. |
51b1df3
to
ed9360d
Compare
@kozhukalov thanks for the PR! Can you show the output printed from the new logs? |
Now it is clear from the log table why some PEC strategies are better that others. Fixes unitaryfund#2013
After we merged this #2038 and with this change the output looks like
|
ed9360d
to
ccbc64d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the slow review. This is great to have.
Description
Now it is clear from the log table why
some PEC strategies are better that others.
Fixes #2013
License
Before opening the PR, please ensure you have completed the following where appropriate.