Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update workflow images in documentation #2034
Update workflow images in documentation #2034
Changes from 13 commits
a3e71f1
ed21ea7
7263f17
947b488
dbdaf10
dbd9e90
c057002
db9780d
aba3f8b
ceffa9f
3a9b1f0
870420e
5ba6799
5454f99
d40e1e6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mitiq.shadows
in the center box instead ofmitiq.classicalshadows
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we do. According to the docs. See step 1 in this section of the docs.
Thanks for catching that! I did not double-check the API-doc. Only followed what the previous images stated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is the "user defined input" section, however. I think that part of the code to ensure we are using a realistic executor. That is not something that happens in the
mitiq.shadows
module, which this diagram is explaining.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you prefer to have
Insert noisy channel
moved to the hardware region?Otherwise, I don't know how to explain the difference between the workflows for ideal classical shadows and robust shadows. The way I understand it, we use the latter in the former after the device noise is characterized.
OR
Step 2
could be changed toNoisy Z-basis measurement
where the noise is user-defined or the one characterized from the robust shadows workflow.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see this diagram as explaining what happens under the hood, and I cannot find anywhere in the
mitiq.shadows
module where we add a noise channel. I can see we apply random Paulis inshadow_quantum_processing
, but don't see any insertion/application of a noise channel, which is why I think that part may be unnecessary. If you agree this is the purpose of the image, can you show me where I'm missing this part?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally can't understand the details of
robust shadow
in Mitiq. I looked at what the main reference of this technique does. https://arxiv.org/abs/2011.09636Step 7 is where the device noise is characterized.
Steps 8, 9 and 10 are where the classical shadows workflow comes into play.
How about I remove the
insert noisy channel
part and make changes toStep 2
? It would then be labeled asNoisy Z-basis measurement
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just in case anyone is following along, Purva and I chatted and agreed her suggestion sounds good. We will go forward with that.