Speed up a few tests #1996
Merged
Speed up a few tests #1996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
co-authored-by: Misty Wahl <[email protected]>
co-authored-by: Misty Wahl <[email protected]>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #1996 +/- ##
==========================================
- Coverage 98.36% 98.27% -0.09%
==========================================
Files 83 86 +3
Lines 3982 4065 +83
==========================================
+ Hits 3917 3995 +78
- Misses 65 70 +5 ☔ View full report in Codecov by Sentry. |
andreamari
approved these changes
Sep 6, 2023
|
Docs build failure is not actually a failure. Looks like it just took a really long time to build. Going forward with merge. |
|
⚡️Great result @natestemen ⚡️! |
Closed
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of #1427 we are trying to speed up tests by removing unnecessary or redundant workloads.
On my machine this brought execution time of
make testdown from 553s to 343s!Reviewer notes
This PR is likely best reviewed commit by commit. Further work needs to be done, but good to make progress over time.
Assigning Nathan + Andrea since Misty and I both worked on this.