-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/int index warnings #777
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report
@@ Coverage Diff @@
## master #777 +/- ##
==========================================
+ Coverage 90.72% 90.94% +0.22%
==========================================
Files 68 68
Lines 6746 6803 +57
==========================================
+ Hits 6120 6187 +67
+ Misses 626 616 -10
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this important update! 🚀
Looks good to me, but it would be good if someone more familiar with xarray could take a look.
Remove Int64Index support and keep only RangeIndex support.
As a consequence, this means that
TimeSeries
cannot have missing dates anymore (which was possible before with Int64Index; RangeIndex do not have holes by construction).I had to adapt
TimeSeries.from_dataframe()
to handle correctly time columns made of integers (and ensure they correctly map to a RangeIndex)__getitem__()
method, becausesel()
on aDataArray
returns an array indexed with an Int64Index (see: Indexing a RangeIndexed' DataArray with a RangeIndex returns a deprecated Int64Index pydata/xarray#6256)Some warnings remain for the time being because of statsmodels.