-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lint: switch flake8
to Ruff
#2323
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this contribution, some minor comments (mostly about fixing E721).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2323 +/- ##
==========================================
- Coverage 94.02% 94.01% -0.02%
==========================================
Files 138 138
Lines 14201 14187 -14
==========================================
- Hits 13353 13338 -15
- Misses 848 849 +1 ☔ View full report in Codecov by Sentry. |
@madtoinou seem all is finally passing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot @Borda for initiating the transition to ruff!
I'll add an entry in the backlog, see if we can find a more elegant solution to these "type checks" to get ride of the #noqa
in the long run.
Checklist before merging this PR:
Fixes #2195
Summary
Switch lint
flake8
to Ruff with the same basic checks.As follow-up, we could also merge Black +
pyupgrade
+isort
(after merging this one I'll prepare separate PRs for each of them)Other Information