fix: time index intersection for coefficient of variation #2202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2202 +/- ##
==========================================
- Coverage 93.88% 93.87% -0.02%
==========================================
Files 135 135
Lines 13425 13412 -13
==========================================
- Hits 12604 12590 -14
- Misses 821 822 +1 ☔ View full report in Codecov by Sentry. |
VascoSch92
reviewed
Feb 1, 2024
dennisbader
approved these changes
Feb 2, 2024
There was a problem hiding this comment.
Looks great, thanks @madtoinou.
We could maybe take this chance, to update the return docs for all metrics? In the end the docs are user facing and it might be misleading if the return type does not reflect both cases handled by the wrappers.
…e multi_ts and multivariate decorator, which convert arrays into list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2157.
Summary
_get_values_or_raiseincoefficient_of_variationto have the appropriate denominator whenintersect = True