switch to Windows code page 65001 in exe:unison and exe:tests #2917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think it's only needed in these two spots, as the other executables just shell out to `stack exec unison`. I'm not actually clear on how this interacts with (or could be replaced by `hSetEncoding`, which we do have sprinkled around already, but not sufficiently to let Windows builds work. If there's a cleaner solution, I'd like to use it. i.e. am I papering over a more correct multi-platform fix by using the Windows-only System.IO.Codepage?
aryairani
force-pushed
the
topic/cp65001
branch
from
0209fae to
87e58af
Compare
21 tasks
|
Should this be behind a cpp flag, only taking effect if the OS is windows? I was under the impression that codepages for console output was just a janky windows only thing and consoles on other platforms can just print arbitrary unicode. Do you know what effect it has when it's set on other platforms? |
|
@pchiusano The CPP flag is inside the library calls. |
|
pchiusano
approved these changes
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's only needed in these two spots, as the other executables just shell out to
stack exec unison.I'm not actually clear on how this interacts with (or could be replaced by
hSetEncoding, which we do have sprinkled around already, but not sufficiently to let Windows builds work. If there's a cleaner solution, I'd like to use it. i.e. Am I papering over a more correct multi-platform fix by using the Windows-onlySystem.IO.Codepage?See https://hackage.haskell.org/package/code-page-0.2.1/docs/src/System.IO.CodePage.html#withCodePage