Add single argument form of diff.namespace #2303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryairani
reviewed
Aug 7, 2021
The output for ``` .b2> diff.namespace .b1 ``` should be the same as the output for ``` .> diff.namespace b1 b2 ``` What the heck?
sullyj3
force-pushed
the
diffWithCurrentNamespace
branch
from
fa7568c to
36719e6
Compare
|
Ok I'm happy with this, let me know if I need to add any more tests/other forms of testing. |
|
Great, thanks so much for knocking this out. I have definitely missed this. |
pchiusano
approved these changes
Aug 11, 2021
|
No problem |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
You can now do
.> diff.namespace beforeto diff
beforewith the current namespace.Closes #1531
Implementation notes
Modifies the appropriate
InputPatternInteresting/controversial decisions
None, fairly straightforward change
Test coverage
Added a line to
diff.mdto check for same output as two argument form.Loose ends
none.