Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{-#COMPLETE#-} seems to have been fixed #2192

Merged
merged 2 commits into from
Jul 10, 2021
Merged

Conversation

aryairani
Copy link
Contributor

Until recently we weren't able to make use of the COMPLETE pragma for Reference pattern synonyms; but now we can, apparently.

-- A good idea, but causes a weird problem with view patterns in PatternP.hs in ghc 8.4.3
--{-# COMPLETE Builtin, Derived #-}

at some point between 8.4.3 and 8.10.4
@aryairani
Copy link
Contributor Author

Just kidding; why does it build on my machine but not in CI???

@aryairani
Copy link
Contributor Author

aryairani commented Jul 10, 2021

@mitchellwrosen FYI — In #1751 we weren't sure if situations could arise where caching .stack-work could cause an incorrect build, but I ran into one here. See the build failure on the first commit vs the second; I also needed a stack clean locally to build correctly.

@aryairani aryairani merged commit e8dd1d5 into trunk Jul 10, 2021
@aryairani aryairani deleted the topic/reference-complete branch July 10, 2021 04:48
@pchiusano pchiusano mentioned this pull request Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants