Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -haddock flag to help haskell-language-server #1823

Merged
merged 1 commit into from
Feb 26, 2021

Conversation

seagreen
Copy link
Contributor

(See this issue: haskell/haskell-language-server#208)

Adding -haddock gives doc-on-hover for 3rd party libraries like megaparsec.

I tested this on a big codebase (>20k SLOC) and compile times stayed the same.

(See this issue: haskell/haskell-language-server#208)

Adding -haddock gives doc-on-hover for 3rd party libraries like megaparsec.

I tested this on a big codebase (>20k SLOC) and compile times stayed the same.
@seagreen
Copy link
Contributor Author

Would close #1821

Copy link
Contributor

@aryairani aryairani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aryairani aryairani merged commit ffccd11 into unisonweb:trunk Feb 26, 2021
@aryairani
Copy link
Contributor

aryairani commented Feb 26, 2021

Pro tip: Put Closes #1821 or even Would close #1821 or another of a number of similar phrases into a commit subject or body, and Github will automatically close the corresponding issue when the PR is merged.

@pchiusano pchiusano mentioned this pull request May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants