Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add multiple ubuntu and osx build images #1617

Merged
merged 2 commits into from
Jun 19, 2020
Merged

add multiple ubuntu and osx build images #1617

merged 2 commits into from
Jun 19, 2020

Conversation

aryairani
Copy link
Contributor

@aryairani aryairani commented Jun 17, 2020

Closes #1616.

This matrix provides builds for:
macOS 10.15.4, Xcode 11.6
macOS 10.14.6, Xcode 11.3.1
Ubuntu Bionic 18.04
Ubuntu Xenial 16.04
Ubuntu Trusty 14.04 (the one we'd been using so far)

This may be overboard, and I wouldn't object to removing some if requested. We can run 5 jobs in parallel on the Travis OSS plan (across all branches).

@aryairani aryairani marked this pull request as draft June 17, 2020 21:40
@aryairani
Copy link
Contributor Author

aryairani commented Jun 17, 2020

Geez. The cached ghc build is somehow busted?

0.98s$ stack --no-terminal build
Building all executables for `easytest' once. After a successful build of all of them, only specified executables will be rebuilt.
easytest                 > configure (lib + exe)
easytest                 > /Users/travis/.stack/setup-exe-cache/x86_64-osx/Cabal-simple_mPHDZzAJ_3.0.1.0_ghc-8.8.3: /Users/travis/.stack/setup-exe-cache/x86_64-osx/Cabal-simple_mPHDZzAJ_3.0.1.0_ghc-8.8.3: cannot execute binary file
unison-core              > configure (lib)
unison-core              > /Users/travis/.stack/setup-exe-cache/x86_64-osx/Cabal-simple_mPHDZzAJ_3.0.1.0_ghc-8.8.3: /Users/travis/.stack/setup-exe-cache/x86_64-osx/Cabal-simple_mPHDZzAJ_3.0.1.0_ghc-8.8.3: cannot execute binary file

So before it can be merged, we need to see it build successfully when using the cache, if we're going to use caching.

Comment on lines +23 to +25
before_cache:
# this was getting corrupted in the cache for osx ??
- rm -rf /Users/travis/.stack/setup-exe-cache
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a support issue open with Travis for this.

And, I'd like to know if any other cache entries are getting corrupted, but I'm out of steam to:

  1. delete the cache
  2. construct the magic web request to launch a debug container
  3. tmate in and manually run the build with no cache (half an hour)
  4. figure out how to find + xargs + sha1sum
  5. run regular build to populate cache (another half an hour)
  6. run a debug build, tmate in, and re-sha1 the tree

Comment on lines -19 to +31
- travis_retry curl -L https://get.haskellstack.org/stable/linux-x86_64.tar.gz | tar xz --wildcards --strip-components=1 -C ~/.local/bin '*/stack'
- travis_retry curl -sSL https://get.haskellstack.org/ | sh
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slurped up into this PR by accident.

@@ -1,22 +1,34 @@
# https://docs.haskellstack.org/en/stable/travis_ci/
# run on containerized infrastructure hopefully
dist: trusty
sudo: false
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dist: trusty moves into the jobs: matrix below
sudo: false is deprecated/ignored

@aryairani aryairani marked this pull request as ready for review June 18, 2020 22:32
Copy link
Member

@pchiusano pchiusano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't investigate the CI failure but LGTM otherwise.

@pchiusano pchiusano merged commit 1a635c9 into master Jun 19, 2020
@pchiusano pchiusano deleted the osx-ci branch June 19, 2020 21:51
@pchiusano pchiusano mentioned this pull request May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add mac builds to CI
2 participants