Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC][NI] Add (limited) tree-shaking capabilities #310

Merged
merged 5 commits into from
Mar 13, 2019
Merged

[RFC][NI] Add (limited) tree-shaking capabilities #310

merged 5 commits into from
Mar 13, 2019

Conversation

AndreJoaquim
Copy link
Contributor

@AndreJoaquim AndreJoaquim commented Mar 12, 2019 •
edited
Loading

Closes #279.

AndreJoaquim
AndreJoaquim commented Mar 12, 2019
View reviewed changes
addon/styles/addon.scss
@@ -1,46 +1,46 @@
@import "node_modules/uniplaces-uniq/src/styles/_main";

@import "partials/uni-textarea",
@import "partials/uni-alert",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ordered by natural order

@AndreJoaquim AndreJoaquim changed the title [WIP][NI] Add (limited) tree-shaking capabilities [RFC][NI] Add (limited) tree-shaking capabilities Mar 12, 2019
rntdrts
rntdrts reviewed Mar 12, 2019
View reviewed changes
rntdrts
rntdrts reviewed Mar 12, 2019
View reviewed changes
rntdrts
rntdrts reviewed Mar 12, 2019
View reviewed changes
rntdrts
rntdrts approved these changes Mar 12, 2019
View reviewed changes
Copy link
Contributor

@rntdrts rntdrts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just left some suggestions and some doubts... nothing major though.

well done! 👏

@AndreJoaquim AndreJoaquim merged commit 409c3d2 into master Mar 13, 2019
@AndreJoaquim AndreJoaquim deleted the treeshaking branch March 13, 2019 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rntdrts rntdrts rntdrts approved these changes

@jkrnak jkrnak jkrnak approved these changes

@henrmota henrmota Awaiting requested review from henrmota

@tlfbrito tlfbrito Awaiting requested review from tlfbrito

@DaniFrancisco DaniFrancisco Awaiting requested review from DaniFrancisco

Assignees
No one assigned
Labels
enhancement
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndreJoaquim @rntdrts @jkrnak