[RFC][NI] Add Enumerable super-class #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreJoaquim
requested review from
DaniFrancisco,
rntdrts,
mmelo,
migueldemoura and
hfcorreia
mmelo
approved these changes
Sep 14, 2018
AndreJoaquim
force-pushed
the
NI/add-enumerable-super-class
branch
from
0c498f1 to
64c3ff6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NI
Motivation:
In every new project, we're always including (i.e. copy+paste) the
types.jsfile containing a super class to empower ourEmberObjects that represent enumerables.Therefore, I decided to add
enumerable.js-- an EmberObject sub-class and copy oftypes.js-- and have all enumerables inherit from it.From now on,
enumerable.jsshould be used andtypes.jsis from this PR on deprecated. The release containing this PR must have a migration guide, although this is not a breaking change, but rather an additional functionality.