Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC][UN-14262 & UN-13756] Remove uniq bower dependency and update ember to 2.18 #262

Merged
merged 7 commits into from
Sep 14, 2018
Merged

[RFC][UN-14262 & UN-13756] Remove uniq bower dependency and update ember to 2.18 #262

merged 7 commits into from
Sep 14, 2018

Conversation

migueldemoura
Copy link
Contributor

@migueldemoura migueldemoura commented Aug 29, 2018 •
edited by AndreJoaquim
Loading

https://uniplaces.atlassian.net/browse/UN-14262 & https://uniplaces.atlassian.net/browse/UN-13756

Removes bower, updates ember to 2.18 and cleans up the repo.

@migueldemoura migueldemoura force-pushed the UN-14262/Remove-bower-dependency-from-ember-cli-uniq branch 5 times, most recently from c06f18a to 97e668a Compare August 29, 2018 16:41
@migueldemoura migueldemoura changed the title [WIP][UN-14262] Remove bower dependency [RFC][UN-14262] Remove bower dependency Aug 31, 2018
AndreJoaquim
AndreJoaquim suggested changes Aug 31, 2018
View reviewed changes
Copy link
Contributor

@AndreJoaquim AndreJoaquim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed you updated ember to 2.18.x. It would have been preferable to do it in a separate PR, in order to track it better.

@AndreJoaquim AndreJoaquim changed the title [RFC][UN-14262] Remove bower dependency [RFC][UN-14262] Remove bower dependency and update ember to 2.18 Aug 31, 2018
@AndreJoaquim AndreJoaquim changed the title [RFC][UN-14262] Remove bower dependency and update ember to 2.18 [RFC][UN-14262] Remove uniq bower dependency and update ember to 2.18 Aug 31, 2018
@AndreJoaquim AndreJoaquim changed the title [RFC][UN-14262] Remove uniq bower dependency and update ember to 2.18 [RFC][UN-14262 & UN-13756] Remove uniq bower dependency and update ember to 2.18 Sep 10, 2018
@migueldemoura migueldemoura force-pushed the UN-14262/Remove-bower-dependency-from-ember-cli-uniq branch 2 times, most recently from d0da3d9 to b4f61d4 Compare September 12, 2018 16:04
@AndreJoaquim AndreJoaquim force-pushed the UN-14262/Remove-bower-dependency-from-ember-cli-uniq branch from b4f61d4 to 263a0e3 Compare September 14, 2018 15:06
@AndreJoaquim AndreJoaquim merged commit a31a3bc into master Sep 14, 2018
@AndreJoaquim AndreJoaquim deleted the UN-14262/Remove-bower-dependency-from-ember-cli-uniq branch September 14, 2018 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmelo mmelo mmelo approved these changes

@AndreJoaquim AndreJoaquim AndreJoaquim approved these changes

@DaniFrancisco DaniFrancisco Awaiting requested review from DaniFrancisco

Assignees
No one assigned
Labels
breaking change
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@migueldemoura @mmelo @AndreJoaquim