[RFC][UN-14114] Add groups to uni select

[carantunes]

https://uniplaces.atlassian.net/browse/UN-14114

[AndreJoaquim]

After already talking with @carantunes, I don't think that this is not the best solution for this problem. I think that it's not good to be able to have two separate APIs for the same component -- groups vs. options.

One of the problems is the following: what will happen when someone invokes {{uni-select groups=groups options=options}}?

Also, this solution doesn't allow to create a uni-select with groups and regular options under the same <select>.

My suggestion, and the one I believe is the most correct solution, is having an optional field inside the option object passed to the uni-select component:

const selectOptions: [{
    label: ‘this is a group’,
    options: [] // If it has options, it'll behave as a group
  },
  {
    label: 'this is a regular option'
  }
]

and invoking the component as we already do:

{{uni-select options=selectOptions}}

This will lead to:

• Not having possible conflict situations: groups and options parameters both being passed
• Keeping the same API: when we want to add groups to already existent uni-select, it's adding the options array
• Allowing optgroups and options to co-exist

[AndreJoaquim]

You can use computed.gt('groups.length', 0)

[carantunes]

I don't think its a good behaviour to have both options alone and groups in the same select. Its confusing to select an option without group, and not being able to select a group.

Having that said and as this is an improvement to the code and as there's no other select with groups in the works, i suggest creating a ticket for the frontend guild and i can tackle it in the next sprint.

[henrmota]

🔝

[henrmota]

this has more than 120 chars?

[carantunes]

exactly 120 😆

[henrmota]

let options = group ? A(this.get('groups')).findBy('key', group).options : this.get('options');