Prevent dynamic dates from being included in test suite. #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Info for policy and roles returns created date. - The simple solution is to filter those results out of the suite.
Merged
- This is the date, and will differ in tests.
terjekv
commented
Dec 8, 2023
| @@ -98,7 +98,7 @@ | |||
| } | |||
| }, | |||
| { | |||
| "output": "Zone: example.org\n Nameservers: hostname TTL\n ns1.example.org <not set>\nPrimary ns: ns1.example.org\nEmail: [email protected]\nSerialnumber: 3231206000\nRefresh: 10800\nRetry: 3600\nExpire: 1814400\nSOA TTL: 43200\nDefault TTL: 43200" | |||
| "output": "Zone: example.org\n Nameservers: hostname TTL\n ns1.example.org <not set>\nPrimary ns: ns1.example.org\nEmail: [email protected]\nSerialnumber: 3231208000\nRefresh: 10800\nRetry: 3600\nExpire: 1814400\nSOA TTL: 43200\nDefault TTL: 43200" | |||
There was a problem hiding this comment.
What I don't understand is why the Serialnumber for the Zone changed. :(
There was a problem hiding this comment.
Weird, but nothing in this PR should have changed that, and the tests pass in CI...
|
https://github.com/spulec/freezegun could help here |
|
Looking at something like freezegun in the longer term is probably not a bad idea. We're not doing any comparisons between times and dates on the client and server anyway, so it should be safe. Yes, I have had the misfortune of debugging why mocking dates didn't work, only to realise I was checking against a timestamp generated by the server, who had zero understanding of my desire to mock dates. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will again break the current tests...