-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade Node.js and related nix files #1325
Conversation
Site/Docs 🤠✨ Deployment complete! Take a peek over at https://9b10d23d.docs-19u.pages.dev 2024-02-07T02:02:52Z |
App 🤌✨ Deployment complete! Take a peek over at https://ce43b309.app-1b1.pages.dev 2024-02-07T02:02:52Z |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR! node
projects are the most difficult to package/manage in Nix for sure bc of the node-gyp
stuff, and you managed to find a way for us to be on the latest versions of dependencies without issues with sharp. Great job sir
b734450
7b74e9c
to
b734450
Compare
Summary:
svelte-language-server
andtypescript-language-server
to latest.@PoisonPhang suggested following our current approach when we need to use the latest version of a tool: this Node.js upgrade follows our current approach by supplying a separate
nixpkgs
, the same way we nixifysolc
andgo
:union/flake.nix
Line 12 in dfbd745
Why upgrade:
svelte-language-server
andtypescript-language-server
as they were quite behind in terms of what versions ofsvelte
andtypescript
they covered,npm
to v10,node-gyp
issue. It hasn't been possible to update Astro since every version post-4.0.9
resulted in that nastysharp
xnode-gyp
issue. To overcome that issue, I tested a scenario that worked: building thesite
with Node.js v21 and overridingsharp
version. To overridesharp
's version, simply addingsharp
topackage.json
doesn't work because other dependencies also havesharp
as their dependency with different versions:npm
'soverrides
field which lets me override the version of any dependency down the tree. So now: