Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): build tools in their respective module #450

Merged
merged 1 commit into from
Apr 30, 2023
Merged

fix(ci): build tools in their respective module #450

merged 1 commit into from
Apr 30, 2023

Conversation

antoineco
Copy link
Contributor

Prerequisite checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Ran make fmt on your commit series before opening this PR;
  • Updated relevant documentation.

Description of changes

The build of these tools is currently broken on staging since the removal of go.work in #407.

@antoineco antoineco added kind/fix This PR fixes an issue or bug area/.github/workflows Issue or PR related to GitHub Actions workflows labels Apr 30, 2023
@antoineco antoineco requested a review from nderjung April 30, 2023 10:21
This was referenced Apr 30, 2023
Merged
Merged
Merged
@nderjung nderjung self-assigned this Apr 30, 2023
nderjung
nderjung approved these changes Apr 30, 2023
View reviewed changes
Copy link
Member

@nderjung nderjung left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Approved-by: Alexander Jung [email protected]

@nderjung nderjung merged commit 5777bdc into unikraft:staging Apr 30, 2023
@antoineco antoineco deleted the fix-tools-workflows branch April 30, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nderjung nderjung nderjung approved these changes

Assignees

@nderjung nderjung

Labels
area/.github/workflows Issue or PR related to GitHub Actions workflows kind/fix This PR fixes an issue or bug
Projects
KraftKit Roadmap
Status: 🚀 Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antoineco @nderjung