fix(library): Add tty stdio configuration #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
razvand
requested review from
andreittr,
StefanJum,
raresgoidescu and
sculamacaz
razvand
force-pushed
the
razvand/update/posix-tty-stdio
branch
from
1fe2f62 to
f52acde
Compare
Unikraft PR #1437 introduced the `LIBPOSIX_TTY_STDIO` config option. This must be enabled in order to use standard descriptors. In particular, this enables applications to print to standard output. If the option is not enabled, nothing is printed. It seems as if the application is doing nothing or hangs (in case of servers). Enable the `LIBPOSIX_TTY_STDIO` in `Kraftfile`s for native and binary-compatibility library builds. Signed-off-by: Razvan Deaconescu <[email protected]>
razvand
force-pushed
the
razvand/update/posix-tty-stdio
branch
from
f52acde to
12b480d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unikraft PR #1437 introduced the
LIBPOSIX_TTY_STDIOconfig option. This must be enabled in order to use standard descriptors. In particular, this enables applications to print to standard output. If the option is not enabled, nothing is printed. It seems as if the application is doing nothing or hangs (in case of servers).Enable the
LIBPOSIX_TTY_STDIOinKraftfiles for native and binary-compatibility library builds.