Fix pausing within Thumb2 ITE blocks (#853) #880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
interesting, but this is just a stopgap solution. can you have a proper fix for this issue? |
|
A proper fix for the issue would require a greater understanding of unicorn and qemu itself. We've looked into it but don't have the resources to find another fix since the current solution addresses our issues. |
AlexanderEichner
added a commit
to PSPReverse/unicorn
that referenced
this pull request
Jun 4, 2020
…ine#880 which might affect executing the AMD secure OS causing a data abort
|
merged, thanks! |
|
Thanks for merging! |
wtdcode
added a commit
to wtdcode/unicorn
that referenced
this pull request
Jul 13, 2021
…icorn-engine#880)" This reverts commit 34ddafc.
maiyao1988
pushed a commit
to maiyao1988/unicorn
that referenced
this pull request
Jan 22, 2022
…icorn-engine#880)" because it will make hook_code for it block invaild 回退这个版本修改会导致在it block里面调用emu stop会导致it block有问题，这是原有bug，但是不能这样修改 This reverts commit 34ddafc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix to issue #853 where restarting the emulator during ITE instructions would lead to incorrect operations.
While there seems to be code addressing the topic using condexec_bits, locating their underlying issue may be a better fix for another time. This solution ignores tracing instructions within ITE blocks (where condexec_mask should be greater than zero) and on IT instructions which prevents emulation from halting and breaking the code.