ulsp: unidoc chokes on 'parser', skip it for now #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don-Ward
requested changes
Sep 15, 2024
uni/ulsp/database.icn
Outdated
|
|
||
| pop(db_paths) # remove the current directory | ||
|
|
||
| write("Looking in:") |
There was a problem hiding this comment.
Should there be some extra writes that print out each directory that is added?
There was a problem hiding this comment.
We print it down below, but there was a duplicate "Looking in" that I took out now.
uni/ulsp/database.icn
Outdated
|
|
||
| write("Looking in:") | ||
| every dir := !ipaths_get() do | ||
| # remove the current dir, also skip pasrer due to a unidoc bug |
uni/ulsp/database.icn
Outdated
| write("Looking in:") | ||
| every dir := !ipaths_get() do | ||
| # remove the current dir, also skip pasrer due to a unidoc bug | ||
| if not((dir == ("." | "")) | find("parser", dir))then |
There was a problem hiding this comment.
I think this might be a bit too sweeping. It removes any path with "parser" somewhere in it. I think I'd prefer "uni/parser"
Signed-off-by: Jafar Al-Gharaibeh <[email protected]>
Jafaral
force-pushed
the
ulsp-fix-parser
branch
from
5263dab to
027050d
Compare
|
Is this new behavior with UniDoc and parser.icn or was parser.icn never passed to UniDoc before? I can take a look at it from the UniDoc to see why it's unhappy... |
ValG4
pushed a commit
to ValG4/unicon
that referenced
this pull request
Dec 7, 2024
ulsp: unidoc chokes on 'parser', skip it for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.