ulsp: socket reading fix #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jafaral
requested changes
May 3, 2024
| request_body := move(len) | ||
| msg := tab(0) | ||
| } | ||
| until *request_body = len do { |
There was a problem hiding this comment.
This has the potential of running infinitely. I recommend adding a select() with a 5 seconds timeout, maybe in a loop with 1 second increment, after that, consider that a malformed msg and move on.
Signed-off-by: Maximus Streeter <[email protected]>
Jafaral
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes unhandled case where client hasn't finished sending data for body of a header + body pair.