Clean up GenerateBreakTest #975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder if @aheninger might want to take a look. |
markusicu
approved these changes
Nov 27, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fulfils the following action item:
UTC-155-A89 Robin Leroy, PAG Document extra classes used for testing characters in the segmentation test HTML files for 11.0. [E.g. ZWJ_FE, CM1_CM, etc.] (Retargeted for 13.0, 14.0, 15.0.)
It also fixes #354.
It also changes the pair table in LineBreakTest.html to show the three way direct/indirect/prohibited break distinction (across spaces), like the old pair table in UAX14 (see https://www.unicode.org/notes/tn54/alba-2.html?v=9.0.0).
As in #970, the test files are not diffable, but I tested them with ICU.
I tried improving the stability of the sample generation a little bit, but it is not as fancy as what Mark suggests in https://www.unicode.org/notes/tn54/alba-2.html?v=9.0.0#p478. I might do that in another PR.