Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(license): update LICENSE and README.md #521

Merged
merged 3 commits into from
Aug 21, 2023
Merged

chore(license): update LICENSE and README.md #521

merged 3 commits into from
Aug 21, 2023

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Aug 15, 2023

@srl295 srl295 requested review from markusicu, annebright and a team August 15, 2023 23:42
@srl295 srl295 self-assigned this Aug 15, 2023
@annebright
Copy link

Looks good except I don't think we need/want the reference to Maven in the ReadMe. Otherwise fine.

@srl295
Copy link
Member Author

srl295 commented Aug 16, 2023

fixed

annebright
annebright previously approved these changes Aug 17, 2023
View reviewed changes
@srl295 srl295 requested a review from annebright August 18, 2023 18:02
annebright
annebright suggested changes Aug 18, 2023
View reviewed changes
Copy link

@annebright annebright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

License title did not get changed to new UNICODE LICENSE V3.
Also, I did not designate this repo to get the reference to Maven, but do you know something that I do not that suggests we need the Maven reference?

srl295
srl295 commented Aug 18, 2023
View reviewed changes
LICENSE Show resolved Hide resolved
@srl295
Copy link
Member Author

srl295 commented Aug 18, 2023

License title did not get changed to new UNICODE LICENSE V3. Also, I did not designate this repo to get the reference to Maven, but do you know something that I do not that suggests we need the Maven reference?

  • It did get changed
  • The maven reference was an error and was fixed 3 days ago.

@srl295 srl295 requested a review from annebright August 18, 2023 21:37
annebright
annebright suggested changes Aug 18, 2023
View reviewed changes
Copy link

@annebright annebright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Maven reference seems to still be there in the ReadMe notice

@srl295
Copy link
Member Author

srl295 commented Aug 18, 2023 •
edited
Loading

The Maven reference seems to still be there in the ReadMe notice

I'm not seeing it. If you go to the Files Changed tab this is what it shows me.

image

What's the exact URL where you're seeing the maven notice?

@markusicu
Copy link
Member

The Maven reference seems to still be there in the ReadMe notice

I'm not seeing it.

me neither

annebright
annebright approved these changes Aug 18, 2023
View reviewed changes
Copy link

@annebright annebright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well now I am not seeing it either, so approved.

@srl295 srl295 merged commit 0a889ad into main Aug 21, 2023
9 checks passed
@srl295 srl295 deleted the srl295/licensev3 branch August 21, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annebright annebright annebright approved these changes

@markusicu markusicu Awaiting requested review from markusicu

Assignees

@srl295 srl295

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srl295 @annebright @markusicu