-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more exhaustive syntax tests (#843) #844
Conversation
The validation CI check is failing because I used the |
Tests may already include a message-format-wg/test/schemas/v0/tests.schema.json Lines 135 to 142 in 4514e88
The spec tests in this repo need to match the schema that's also in this repo. |
Ah, didn't notice that. Fixed. |
Beginning to address #843 and the corresponding item under https://github.com/unicode-org/message-format-wg/wiki/Things-That-Need-Doing .
I tried to test each variation of each rule (up to but not including
identifier
.) I didn't try to test combinations of variations. For example, for this rule:the idea would be to add tests that exercise the following four (partial) derivations:
This isn't exhaustive by any means, but it was broad enough that I found one bug in the ICU4J parser (the
".input{$x}{{}}
test case) and two bugs in the ICU4C parser (the\\\\
test case and the{ #a}
test case).