Clarify that options and attributes are unordered #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eemeli
added
syntax
catamorphism
approved these changes
Mar 25, 2024
aphillips
reviewed
Mar 25, 2024
| @@ -319,7 +319,7 @@ the following steps are taken: | |||
|
|
|||
| #### Option Resolution | |||
|
|
|||
| The result of resolving _option_ values is a mapping of string identifiers to values. | |||
| The result of resolving _option_ values is an unordered mapping of string identifiers to values. | |||
There was a problem hiding this comment.
This might be too strong. An implementation would not be incorrect to order the options internally--that would be an implementation detail. What's important is that functions cannot count on the ordering or make the ordering significant.
There was a problem hiding this comment.
This has that effect. It's still possible for an implementation to use a container that retains order to represent the options, but with this qualifier functions can't rely on that.
There was a problem hiding this comment.
I'm trying to be parsimonious about what we change. The existing text doesn't say anything about order, thus you can't count on it (especially since we disallow ordering elsewhere). But I can live with this.
ZL91
approved these changes
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #749.
See #716 for context.