-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare design doc ahead of balloting #506
Conversation
- Rename the design doc. - Cross out rejected options 2 and 5 - Add notes to 2 and 5 calling this out (other changes may be added from the previous thread in #503 and WG call notes from 2023-10-30)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's fine, though two further changes could be considered:
- The "Proposed Design" section could explicitly call out that we're balloting for which one to pick.
- The 2 & 5 options could have their contents hidden within
<details>
blocks as already used later on in the doc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See line comments for minor fixes.
Co-authored-by: Eemeli Aro <[email protected]>
Co-authored-by: Eemeli Aro <[email protected]>
The last paragraph of the introductory "Summary" section seems rather opinionated. Could it be dropped?
|
It seems pretty straightforward and objective to me. What's opinionated about it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(other changes may be added from the previous thread in #503 and WG call notes from 2023-10-30)