Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare design doc ahead of balloting #506

Merged
merged 4 commits into from
Oct 30, 2023
Merged

Conversation

aphillips
Copy link
Member

  • Rename the design doc.
  • Cross out rejected options 2 and 5
  • Add notes to 2 and 5 calling this out

(other changes may be added from the previous thread in #503 and WG call notes from 2023-10-30)

- Rename the design doc.
- Cross out rejected options 2 and 5
- Add notes to 2 and 5 calling this out

(other changes may be added from the previous thread in #503 and WG call notes from 2023-10-30)
Copy link
Collaborator

@eemeli eemeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine, though two further changes could be considered:

  1. The "Proposed Design" section could explicitly call out that we're balloting for which one to pick.
  2. The 2 & 5 options could have their contents hidden within <details> blocks as already used later on in the doc.

Copy link
Collaborator

@eemeli eemeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See line comments for minor fixes.

exploration/delimiting-variant-patterns.md Outdated Show resolved Hide resolved
exploration/delimiting-variant-patterns.md Outdated Show resolved Hide resolved
exploration/delimiting-variant-patterns.md Outdated Show resolved Hide resolved
exploration/delimiting-variant-patterns.md Outdated Show resolved Hide resolved
exploration/delimiting-variant-patterns.md Outdated Show resolved Hide resolved
exploration/delimiting-variant-patterns.md Outdated Show resolved Hide resolved
@eemeli
Copy link
Collaborator

eemeli commented Oct 30, 2023

The last paragraph of the introductory "Summary" section seems rather opinionated. Could it be dropped?

With the current syntax, the boundary between pattern and the remainder of the message is always clear
because the pattern is either the entire string
or enclosed in the {{...}} quoting required by the syntax.

@echeran
Copy link
Collaborator

echeran commented Oct 30, 2023

The last paragraph of the introductory "Summary" section seems rather opinionated. Could it be dropped?

With the current syntax, the boundary between pattern and the remainder of the message is always clear
because the pattern is either the entire string
or enclosed in the {{...}} quoting required by the syntax.

It seems pretty straightforward and objective to me. What's opinionated about it?

Copy link
Collaborator

@echeran echeran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aphillips aphillips merged commit 2694e3e into main Oct 30, 2023
@aphillips aphillips deleted the aphillips-update-delimiting branch October 30, 2023 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants