Rename FractionalSecondDigits to SubsecondDigits #6139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
force-pushed
the
subsecond
branch
from
19e0df1 to
ced9c02
Compare
Manishearth
force-pushed
the
subsecond
branch
from
ced9c02 to
15d482f
Compare
| /// Two fractional digits (hundredths of a second). | ||
| F2 = 2, | ||
| S2 = 2, | ||
| /// Three fractional digits (thousandths of a second). |
There was a problem hiding this comment.
Suggested change
| /// Three fractional digits (thousandths of a second). | |
| /// Three fractional digits (milliseconds). |
|
I wish to review this; please don't merge before I am able to post a review |
robertbastian
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also renames the enum variants, happy to undo if requested
Fixes #6118