Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate to_string concrete fn in impl_display_with_writeable #5827

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

sffc
Copy link
Member

@sffc sffc commented Nov 15, 2024

Fixes #4590

I made it the default behavior.

@sffc sffc requested a review from Manishearth as a code owner November 15, 2024 07:14
@sffc sffc merged commit dd0e253 into unicode-org:main Nov 15, 2024
28 checks passed
@sffc sffc deleted the writeable-to-string branch November 15, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should we implement pub fn to_string on Writeable concrete types?
2 participants