Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce stack size of DecimalSymbolsV1 #5804

Merged
merged 19 commits into from
Nov 14, 2024

Conversation

Manishearth
Copy link
Member

@Manishearth Manishearth commented Nov 12, 2024

Fixes #4437

This doesn't work yet: there's no easy way to get Bake impls for custom VarULE types since from_byte_slice_unchecked can't be called in const contexts (since you can't do trait stuff in non-const contexts: in theory this function is very const-capable)

I chose to use make_varule but VarTupleNULE would work as well (and plus we can give it the relevant Bake impl if we want). I wrote this PR to encapsulate things so that swapping the internals is easier

I think I'll make this work by implementing ZeroCow: #5561

@Manishearth Manishearth force-pushed the decimalsymbols branch 2 times, most recently from e66127e to 0f7c5d5 Compare November 12, 2024 01:50
@Manishearth Manishearth force-pushed the decimalsymbols branch 3 times, most recently from 0a9b3ca to 89aa8de Compare November 12, 2024 03:01
@Manishearth
Copy link
Member Author

Updated to use #5809 and #5808

@Manishearth Manishearth force-pushed the decimalsymbols branch 7 times, most recently from 3315135 to 76dc094 Compare November 13, 2024 01:37
@Manishearth Manishearth marked this pull request as ready for review November 13, 2024 18:11
ffi/capi/src/decimal.rs Outdated Show resolved Hide resolved
ffi/capi/src/decimal.rs Outdated Show resolved Hide resolved
tutorials/data_provider.md Outdated Show resolved Hide resolved
@Manishearth Manishearth requested a review from sffc November 13, 2024 22:22
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to here but there's still one comment open

sffc
sffc previously approved these changes Nov 13, 2024
@sffc
Copy link
Member

sffc commented Nov 13, 2024

---- datagen::test_markers_for_bin stdout ----
thread 'datagen::test_markers_for_bin' panicked at components/icu/src/datagen.rs:96:5:
assertion `left == right` failed
  left: [datetime/names/dayperiods@1, datetime/names/gregory/months@1, datetime/names/gregory/years@1, datetime/names/weekdays@1, datetime/patterns/glue@1, datetime/patterns/gregory/skeleton@1, datetime/patterns/time_skeleton@1, datetime/week_data@2]
 right: [datetime/names/dayperiods@1, datetime/names/gregory/months@1, datetime/names/gregory/years@1, datetime/names/weekdays@1, datetime/patterns/glue@1, datetime/patterns/gregory/skeleton@1, datetime/patterns/time_skeleton@1, datetime/week_data@2, decimal/symbols@2]

@Manishearth Manishearth merged commit ef5fda1 into unicode-org:main Nov 14, 2024
28 checks passed
@Manishearth Manishearth deleted the decimalsymbols branch November 14, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce stack size of DecimalSymbolsV1
2 participants