-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce stack size of DecimalSymbolsV1 #5804
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e66127e
to
0f7c5d5
Compare
0a9b3ca
to
89aa8de
Compare
sffc
reviewed
Nov 12, 2024
3315135
to
76dc094
Compare
sffc
reviewed
Nov 13, 2024
sffc
reviewed
Nov 13, 2024
76dc094
to
c0bcfaf
Compare
c0bcfaf
to
05e4a2a
Compare
sffc
reviewed
Nov 13, 2024
sffc
reviewed
Nov 13, 2024
sffc
reviewed
Nov 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to here but there's still one comment open
sffc
previously approved these changes
Nov 13, 2024
|
f4d6068
to
cbf0dfe
Compare
sffc
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4437
This doesn't work yet: there's no easy way to get Bake impls for custom VarULE types since
from_byte_slice_unchecked
can't be called in const contexts (since you can't do trait stuff in non-const contexts: in theory this function is very const-capable)I chose to use
make_varule
but VarTupleNULE would work as well (and plus we can give it the relevant Bake impl if we want). I wrote this PR to encapsulate things so that swapping the internals is easierI think I'll make this work by implementing ZeroCow: #5561